Skip to content

chore: migrate AWS SDK for JavaScript v2 APIs to v3 - #32555

Closed
trivikr wants to merge 4 commits into
RocketChat:developfrom
trivikr:codemod
Closed

chore: migrate AWS SDK for JavaScript v2 APIs to v3#32555
trivikr wants to merge 4 commits into
RocketChat:developfrom
trivikr:codemod

Conversation

@trivikr

@trivikr trivikr commented Jun 4, 2024 •
edited by dougfabris
Loading

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Migrates AWS SDK for JavaScript v2 APIs to v3

Issue(s)

Closes #32554

Steps to test or reproduce

N/A

@changeset-bot

changeset-bot Bot commented Jun 4, 2024 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ffa3919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant

CLAassistant commented Jun 4, 2024 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@debdutdeb debdutdeb self-assigned this Jun 5, 2024
@casalsgh
casalsgh requested a review from debdutdeb June 14, 2024 15:44
@trivikr

trivikr commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

@debdutdeb Is there anything else that needs to be done to get this PR reviewed?

@trivikr trivikr mentioned this pull request Jul 1, 2024
Open
@ggazzo
ggazzo removed the request for review from debdutdeb July 8, 2024 12:29
MarcosSpessatto

This comment was marked as duplicate.

Sign in to view

@MarcosSpessatto
MarcosSpessatto self-requested a review July 8, 2024 13:11
MarcosSpessatto
MarcosSpessatto suggested changes Jul 8, 2024
View reviewed changes

@MarcosSpessatto MarcosSpessatto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr first of all, thanks for your contribution. Can you please fix the lint and typecheck?

@trivikr

trivikr commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

Can you please fix the lint and typecheck?

Done.

@trivikr

trivikr commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

@MarcosSpessatto Is there any other action needed from my side to unblock review/merge of this PR?

@ggazzo ggazzo added this to the 6.12 milestone Aug 1, 2024
@dionisio-bot

dionisio-bot Bot commented Aug 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@trivikr

trivikr commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author
  • This PR has conflicts, please resolve them before merging

Done.

@trivikr

trivikr commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author
  • This PR is missing the 'stat: QA assured' label

Will this be done by assignee @debdutdeb, or previous reviewer @MarcosSpessatto?

@trivikr
trivikr requested a review from MarcosSpessatto August 1, 2024 20:59
@ggazzo

ggazzo commented Aug 22, 2024

Copy link
Copy Markdown
Member

@trivikr I changed the code a bit , but it seems the upload is not working could you please confirm if it works?

@rodrigok rodrigok modified the milestones: 6.12, 6.13 Aug 22, 2024
@trivikr

trivikr commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

but it seems the upload is not working

What's the error that you're getting?

@scuciatto scuciatto modified the milestones: 6.13, 6.14 Sep 30, 2024
@scuciatto scuciatto removed this from the 6.14 milestone Oct 15, 2024
@ggazzo
ggazzo requested a review from a team as a code owner March 5, 2026 03:38
@ricardogarim

ricardogarim commented Mar 9, 2026

Copy link
Copy Markdown
Member

Closing this, as the AWS SDK version update was implemented in #36659.

@trivikr
trivikr deleted the codemod branch March 9, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcosSpessatto MarcosSpessatto Awaiting requested review from MarcosSpessatto

Assignees

@debdutdeb debdutdeb

Labels

stat: conflict

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate AWS SDK for JavaScript v2 APIs to v3

9 participants

@trivikr @CLAassistant @ggazzo @ricardogarim @MarcosSpessatto @rodrigok @scuciatto @KevLehman @debdutdeb