-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: E2EE warnings on search and audit panel #32551
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7f4c3c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32551 +/- ##
===========================================
- Coverage 56.62% 56.54% -0.08%
===========================================
Files 2486 2482 -4
Lines 54921 54876 -45
Branches 11364 11358 -6
===========================================
- Hits 31097 31032 -65
- Misses 21151 21163 +12
- Partials 2673 2681 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we're adding unnecessary complexity in the user experience. Basically we're adding the support for finding the encrypted rooms and when they select, we warn them they can't proceed with what they want (audit feature). If the issue is that users are being frustrated because they don't know they can't use these features for e2e encryption we're failing on the explanation of our features. We should look for an alternative to warn them such as displaying these callouts based on e2e being enabled on the workspace, saying they won't be able to find the encrypted channels for example. Kinda similar what you're doing on search messages.
And this change definitely isn't a chore
Thanks for the review doug, and I'm always having hard time figuring out if something is a But the idea is, encrypted rooms are still auditable, and encrypted rooms might contain some un-encrypted messages which can be audited. The warning is just to let the users know about the limitations. If we stop showing encrypted rooms on audit panel then the admin won't be able to see the un-encrypted messages which could still be audited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix errors and implement tests
Tests requirement dismissed due to the nature of this feature, does not worth to do e2e tests to check warning |
Proposed changes (including videos or screenshots)
While end-to-end encryption in Rocket.Chat provides enhanced privacy and security for communications, it inherently restricts certain functionalities, such as auditing messages, searching message content, and interacting with bots within encrypted rooms. Users may not be aware of these limitations, which can lead to confusion and a mismatch between user expectations and the platform's capabilities. Incorporating clear disclaimers into the user interface will help set accurate expectations and improve user satisfaction by transparently communicating the trade-offs involved with encryption.
Issue(s)
Steps to test or reproduce
Further comments
E2EE2-10