fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow #32398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1df6f70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32398 +/- ##
===========================================
- Coverage 55.86% 55.86% -0.01%
===========================================
Files 2432 2432
Lines 53480 53480
Branches 10993 10993
===========================================
- Hits 29877 29874 -3
- Misses 20965 20966 +1
- Partials 2638 2640 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
reviewed
May 13, 2024
KevLehman
previously approved these changes
May 13, 2024
dougfabris
previously approved these changes
May 14, 2024
matheusbsilva137
dismissed stale reviews from dougfabris and KevLehman
via
a2feeaa
dougfabris
approved these changes
May 16, 2024
KevLehman
approved these changes
May 16, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
gabriellsh
added a commit
that referenced
this pull request
May 28, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits) refactor: IntegrationHistory out of DB Watcher (#32502) fix: Message update being broadcasted without updated values (#32472) test: make api teams test fully independent (#31756) test: Fix test name (#32490) fix: streams being called with no logged user (#32489) feat: Un-encrypted messages not allowed in E2EE rooms (#32040) feat(UiKit): Users select (#31455) fix: Re-login same browser tab issues (#32479) chore: move all webclient code out of the COSS folders (#32273) chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619) fix: Don't show join default channels option for edit user form (#31750) fix: CAS user merge not working (#32444) fix: Overriding Retention Policy not working (#32454) fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364) fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398) fix: Bypass trash when removing OTR system messages and read receipts (#32269) fix: Monitors dissapearing from Unit upon edit (#32393) fix: Link image preview not opening in gallery (#32391) feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439) regression: Users tab misaligned (#32451) ...
matheusbsilva137
added a commit
that referenced
this pull request
May 31, 2024
…n the "Forgot Password" flow (#32398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Accounts_AllowPasswordChangeForOAuthUsersin theusers.forgotPasswordendpoint.Issue(s)
Steps to test or reproduce
Current behavior: the reset password e-mail is sent (even to LDAP/OAuth users that didn't have a password before);
Expected behavior: the reset password e-mail should not be sent.
Further comments
CORE-439