Skip to content

fix: search room not reactive after room name changes #32123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Apr 3, 2024
Merged

fix: search room not reactive after room name changes #32123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3e8f52
Refactor useSearchItems to include room names in spotlight search key
ggazzo Apr 3, 2024
3cc2893
Create sweet-books-trade.mdw
ggazzo Apr 3, 2024
7747bc2
Merge branch 'develop' into test/flaky-edit-name
ggazzo Apr 3, 2024
592f496
Merge branch 'develop' into test/flaky-edit-name
kodiakhq[bot] Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-books-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

fixed search room not showing the new name room name changes
2 changes: 1 addition & 1 deletion apps/meteor/client/sidebar/search/SearchList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const useSearchItems = (filterText: string): UseQueryResult<(ISubscription & IRo
const getSpotlight = useMethod('spotlight');

return useQuery(
['sidebar/search/spotlight', name, usernamesFromClient, type, localRooms.map(({ _id }) => _id)],
['sidebar/search/spotlight', name, usernamesFromClient, type, localRooms.map(({ _id, name }) => _id + name)],
async () => {
if (localRooms.length === LIMIT) {
return localRooms;
Expand Down