Skip to content

regression: Missing ContextualbarDialog wrapping in administration and Omnichannel - #32026

Merged
ggazzo merged 4 commits into
developfrom
reg/adminContextualbarDialog
Mar 19, 2024
Merged

regression: Missing ContextualbarDialog wrapping in administration and Omnichannel#32026
ggazzo merged 4 commits into
developfrom
reg/adminContextualbarDialog

Conversation

@dougfabris

@dougfabris dougfabris commented Mar 19, 2024

Copy link
Copy Markdown
Member

SR-26

Proposed changes (including videos or screenshots)

Introduced here: #31978

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Mar 19, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ae0446d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Mar 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 52.73%. Comparing base (71adf5c) to head (ae0446d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32026      +/-   ##
===========================================
- Coverage    54.65%   52.73%   -1.93%     
===========================================
  Files         2296     2175     -121     
  Lines        50590    48614    -1976     
  Branches     10312     9888     -424     
===========================================
- Hits         27652    25638    -2014     
- Misses       20448    20665     +217     
+ Partials      2490     2311     -179     
Flag Coverage Δ
e2e 50.00% <73.68%> (-3.73%) ⬇️
e2e-api 40.07% <ø> (-0.04%) ⬇️
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris
dougfabris marked this pull request as ready for review March 19, 2024 17:40
@dougfabris
dougfabris requested review from a team as code owners March 19, 2024 17:40
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 19, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@ggazzo
ggazzo merged commit 3c97c99 into develop Mar 19, 2024
@ggazzo
ggazzo deleted the reg/adminContextualbarDialog branch March 19, 2024 22:56
@dougfabris dougfabris added this to the 6.7 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants