Skip to content

test: failing registerGuest function when same token is provided - #31968

Merged
ggazzo merged 1 commit into
developfrom
registerGuestTest
Mar 25, 2024
Merged

test: failing registerGuest function when same token is provided#31968
ggazzo merged 1 commit into
developfrom
registerGuestTest

Conversation

@MartinSchoeler

Copy link
Copy Markdown
Member

This is an existing issue, so I've added the test on how it should be working, skipped it and when we have the feature working again we unskip it with the fix

@changeset-bot

changeset-bot Bot commented Mar 12, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c08cb9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Mar 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (e203c40) to head (c08cb9d).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31968      +/-   ##
===========================================
- Coverage    54.74%   54.73%   -0.01%     
===========================================
  Files         2298     2299       +1     
  Lines        50702    50733      +31     
  Branches     10354    10360       +6     
===========================================
+ Hits         27756    27770      +14     
- Misses       20450    20468      +18     
+ Partials      2496     2495       -1     
Flag Coverage Δ
e2e 53.75% <ø> (+0.01%) ⬆️
e2e-api 40.04% <ø> (-0.04%) ⬇️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
ggazzo force-pushed the registerGuestTest branch from eea8634 to 2297c6e Compare March 14, 2024 02:33
@ggazzo ggazzo added this to the 6.7 milestone Mar 14, 2024
@MartinSchoeler
MartinSchoeler marked this pull request as ready for review March 25, 2024 13:43
@MartinSchoeler
MartinSchoeler requested a review from a team as a code owner March 25, 2024 13:43
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 25, 2024
@ggazzo
ggazzo merged commit 95540f5 into develop Mar 25, 2024
@ggazzo
ggazzo deleted the registerGuestTest branch March 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants