Skip to content

fix: CRM integration mismatch on callback type #31880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 8 commits into from
Mar 12, 2024
Merged

fix: CRM integration mismatch on callback type #31880

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25cfbef
Fix issue on crm integrtion
KevLehman Mar 4, 2024
7df573e
Create slow-jobs-think.md
KevLehman Mar 4, 2024
c7d0751
breaking change
KevLehman Mar 4, 2024
77ffb19
Merge branch 'fix/livechat-started-crm' of github.com:RocketChat/Rock…
KevLehman Mar 4, 2024
4f0a1d0
Update slow-jobs-think.md
KevLehman Mar 6, 2024
3c818cb
tests
KevLehman Mar 11, 2024
ff7faae
Merge branch 'fix/livechat-started-crm' of github.com:RocketChat/Rock…
KevLehman Mar 11, 2024
71664c3
Merge branch 'develop' into fix/livechat-started-crm
kodiakhq[bot] Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-jobs-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

fix: CRM integration mismatch on callback type vs code validation
Comment thread
KevLehman marked this conversation as resolved.
Outdated
16 changes: 13 additions & 3 deletions apps/meteor/app/livechat/server/hooks/sendToCRM.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,16 @@ type OmnichannelRoomWithExtraFields = IOmnichannelRoom & {
oldDepartmentId?: IOmnichannelRoom['departmentId'];
};

type CRMActions =
| 'LivechatSessionStart'
| 'LivechatSessionQueued'
| 'LivechatSession'
| 'LivechatSessionTaken'
| 'LivechatSessionForwarded'
| 'LivechatEdit'
| 'Message'
| 'LeadCapture';

const msgNavType = 'livechat_navigation_history';
const msgClosingType = 'livechat-close';

Expand All @@ -60,10 +70,10 @@ const sendMessageType = (msgType: string): boolean => {
}
};

const getAdditionalFieldsByType = (type: string, room: OmnichannelRoomWithExtraFields): AdditionalFields => {
const getAdditionalFieldsByType = (type: CRMActions, room: OmnichannelRoomWithExtraFields): AdditionalFields => {
Comment thread
KevLehman marked this conversation as resolved.
Outdated
const { departmentId, servedBy, closedAt, closedBy, closer, oldServedBy, oldDepartmentId } = room;
switch (type) {
case 'LivechatSessionStarted':
case 'LivechatSessionStart':
case 'LivechatSessionQueued':
return { departmentId };
case 'LivechatSession':
Expand All @@ -78,7 +88,7 @@ const getAdditionalFieldsByType = (type: string, room: OmnichannelRoomWithExtraF
};

async function sendToCRM(
type: string,
type: CRMActions,
room: OmnichannelRoomWithExtraFields,
includeMessages: boolean | IOmnichannelSystemMessage[] = true,
): Promise<OmnichannelRoomWithExtraFields> {
Expand Down