fix: Fixes SAML Role mapping of custom roles

[tiran133]

Issue(s)

Fixes #31707
CORE-88

#31830

The issue is that the names of the roles get pulled here.

Rocket.Chat/apps/meteor/ee/server/configuration/saml.ts

Line 27 in fe089ff

userObject.roles = savedRoles.map((role) => role.name);

But here only ids get validated here.

Rocket.Chat/apps/meteor/server/lib/roles/validateRoleList.ts

Line 11 in fe089ff

const existingRoleIds = (await Roles.findInIds<Pick<IRole, '_id'>>(roleIds, options).toArray()).map(({ _id }) => _id);

My change solves this problem by just pulling ids.

[changeset-bot]

🦋 Changeset detected

Latest commit: 48823af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (85fe51a) to head (48823af).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31790      +/-   ##
===========================================
+ Coverage    54.58%   54.63%   +0.05%     
===========================================
  Files         2280     2281       +1     
  Lines        50262    50276      +14     
  Branches     10254    10254              
===========================================
+ Hits         27436    27469      +33     
- Misses       20337    20353      +16     
+ Partials      2489     2454      -35     

Flag	Coverage Δ
unit	76.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.