Skip to content

test: make commands test fully independent - #31677

Merged
kodiakhq[bot] merged 2 commits into
developfrom
test/decouple-commands
Feb 7, 2024
Merged

test: make commands test fully independent#31677
kodiakhq[bot] merged 2 commits into
developfrom
test/decouple-commands

Conversation

@MarcosSpessatto

@MarcosSpessatto MarcosSpessatto commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

https://rocketchat.atlassian.net/browse/CORE-185

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto
MarcosSpessatto requested a review from a team as a code owner February 7, 2024 15:46
@changeset-bot

changeset-bot Bot commented Feb 7, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0760ebe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f7554a) 54.36% compared to head (0760ebe) 54.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31677      +/-   ##
===========================================
- Coverage    54.36%   54.33%   -0.03%     
===========================================
  Files         2280     2278       -2     
  Lines        50106    50102       -4     
  Branches     10211    10210       -1     
===========================================
- Hits         27239    27223      -16     
- Misses       20387    20399      +12     
  Partials      2480     2480              
Flag Coverage Δ
e2e 53.19% <ø> (-0.02%) ⬇️
e2e-api 39.80% <ø> (-0.06%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 7, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 7, 2024
@kodiakhq
kodiakhq Bot merged commit 4f3947c into develop Feb 7, 2024
@kodiakhq
kodiakhq Bot deleted the test/decouple-commands branch February 7, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants