Skip to content

regression: Exclude clearRemovedRoomsHistory from L rooms - #31654

Merged
kodiakhq[bot] merged 2 commits into
release-6.6.0from
fix-clearRoom-Omni
Feb 6, 2024
Merged

regression: Exclude clearRemovedRoomsHistory from L rooms#31654
kodiakhq[bot] merged 2 commits into
release-6.6.0from
fix-clearRoom-Omni

Conversation

@MartinSchoeler

@MartinSchoeler MartinSchoeler commented Feb 5, 2024

Copy link
Copy Markdown
Member

OC-1453

@changeset-bot

changeset-bot Bot commented Feb 5, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e419f8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Feb 5, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f71c1be) 53.72% compared to head (e419f8b) 51.82%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.6.0   #31654      +/-   ##
=================================================
- Coverage          53.72%   51.82%   -1.91%     
=================================================
  Files               2266     2135     -131     
  Lines              49670    47407    -2263     
  Branches           10131     9649     -482     
=================================================
- Hits               26687    24569    -2118     
- Misses             20528    20554      +26     
+ Partials            2455     2284     -171     
Flag Coverage Δ
e2e 48.10% <0.00%> (-3.86%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler added this to the 6.6 milestone Feb 5, 2024
@MartinSchoeler MartinSchoeler changed the title fix: Exclude clearRemovedRoomsHistory from L rooms regression: Exclude clearRemovedRoomsHistory from L rooms Feb 5, 2024
@MartinSchoeler
MartinSchoeler marked this pull request as ready for review February 5, 2024 19:07
@MartinSchoeler
MartinSchoeler requested review from a team as code owners February 5, 2024 19:08
@pierre-lehnen-rc

Copy link
Copy Markdown
Contributor

The underlying issue is still there though; This just stops it from happening to 'L' rooms.

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 6, 2024
@kodiakhq
kodiakhq Bot merged commit e587cb1 into release-6.6.0 Feb 6, 2024
@kodiakhq
kodiakhq Bot deleted the fix-clearRoom-Omni branch February 6, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants