feat: Improve 2fa modals and change resend email to button - #31621
Merged
Conversation
Changed the copy of the 2fa modal, added a tagline, changed the resend email link to a button and removed the icon.
Changed the copy, removed the icon and added a tagline to the 2fa TOTP modal.
🦋 Changeset detectedLatest commit: f3fc767 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31621 +/- ##
===========================================
- Coverage 54.39% 54.36% -0.03%
===========================================
Files 2276 2276
Lines 50105 50105
Branches 10227 10227
===========================================
- Hits 27253 27240 -13
- Misses 20369 20389 +20
+ Partials 2483 2476 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
suggested changes
Feb 6, 2024
hugocostadev
left a comment
hugocostadev
left a comment
Contributor
There was a problem hiding this comment.
fix conflicts and add changeset, thanks! 🚀
rique223
changed the title
hugocostadev
previously approved these changes
Feb 6, 2024
dionisio-bot
Bot
added
stat: ready to merge
….Chat into chore/change-2fa-modal
dionisio-bot
Bot
added
stat: ready to merge
hugocostadev
approved these changes
Feb 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Improved the 2fa email and TOTP modals by:
Demo images:
Email modal:
TOTP modal:
Issue(s)
Steps to test or reproduce
Further comments
WM-223