regression: UiKitMessage refreshing room - #31603
Merged
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.6.0 #31603 +/- ##
=================================================
- Coverage 49.56% 49.54% -0.02%
=================================================
Files 3326 3322 -4
Lines 81796 81743 -53
Branches 16881 16872 -9
=================================================
- Hits 40539 40501 -38
+ Misses 36518 36506 -12
+ Partials 4739 4736 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
regression/UiKitMessage-refresh-room
branch
from
February 1, 2024 15:24
8797835 to
8e3011d
Compare
ggazzo
force-pushed
the
regression/UiKitMessage-refresh-room
branch
from
February 1, 2024 15:27
8e3011d to
1c04414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The UiKitMessage was blinking/refreshing the room page due to an action that it was triggering the Suspense, to fix it I've added an inner suspense before the UiKitMessage
Issue(s)
Steps to test or reproduce
Further comments
TC-1099