Skip to content

fix: missing slashcommand permissions - #31594

Merged
ggazzo merged 6 commits into
release-6.6.0from
fix/slash-permission
Feb 1, 2024
Merged

fix: missing slashcommand permissions#31594
ggazzo merged 6 commits into
release-6.6.0from
fix/slash-permission

Conversation

@ggazzo

@ggazzo ggazzo commented Jan 31, 2024

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Jan 31, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9c4d854

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53b934e) 49.54% compared to head (3fec3d4) 59.87%.
Report is 3 commits behind head on release-6.6.0.

❗ Current head 3fec3d4 differs from pull request most recent head 9c4d854. Consider uploading reports for the commit 9c4d854 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.6.0   #31594       +/-   ##
==================================================
+ Coverage          49.54%   59.87%   +10.33%     
==================================================
  Files               3322     1796     -1526     
  Lines              81748    35037    -46711     
  Branches           16874     7302     -9572     
==================================================
- Hits               40501    20980    -19521     
+ Misses             36509    12454    -24055     
+ Partials            4738     1603     -3135     
Flag Coverage Δ
e2e 53.25% <ø> (+0.01%) ⬆️
e2e-api ?
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title fix: missing slashcommand not checking permissions fix: missing slashcommand permissions Feb 1, 2024
@ggazzo
ggazzo force-pushed the fix/slash-permission branch from 5d788ad to 0c12724 Compare February 1, 2024 02:33
@ggazzo
ggazzo changed the base branch from develop to release-6.6.0 February 1, 2024 02:34
@ggazzo
ggazzo force-pushed the fix/slash-permission branch from 0c12724 to f8297a3 Compare February 1, 2024 02:36
@ggazzo
ggazzo marked this pull request as ready for review February 1, 2024 11:54
@ggazzo
ggazzo requested a review from a team as a code owner February 1, 2024 11:54
Comment thread apps/meteor/app/slashcommands-unarchiveroom/server/server.ts Outdated
Comment thread apps/meteor/app/slashcommands-unarchiveroom/server/server.ts Outdated
Comment thread apps/meteor/app/slashcommands-archiveroom/server/server.ts Outdated
Co-authored-by: Diego Sampaio <chinello@gmail.com>
sampaiodiego
sampaiodiego previously approved these changes Feb 1, 2024
@ggazzo
ggazzo merged commit 634793e into release-6.6.0 Feb 1, 2024
@ggazzo
ggazzo deleted the fix/slash-permission branch February 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants