Skip to content

regression: empty attachments leads to a Moderation Console GUI crash - #31592

Merged
kodiakhq[bot] merged 1 commit into
release-6.6.0from
chore_modc_attachment
Feb 1, 2024
Merged

regression: empty attachments leads to a Moderation Console GUI crash #31592
kodiakhq[bot] merged 1 commit into
release-6.6.0from
chore_modc_attachment

Conversation

@Dnouv

@Dnouv Dnouv commented Jan 31, 2024

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

  • We've improved the handling of the attachments[] and files[] arrays in our message processing logic. Previously, there were edge cases where the attachments[] array was present but empty, and the files[] array was not present. This could lead to unexpected behavior. With this update, we've added checks to ensure that the attachments[] array not only exists, but also contains at least one element before attempting to access the files[] array. This makes our reported message processing more robust and prevents potential issues caused by these edge cases.

Issue(s)

Steps to test or reproduce

Further comments

WM-221

@changeset-bot

changeset-bot Bot commented Jan 31, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 488166d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53b934e) 49.54% compared to head (488166d) 49.53%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.6.0   #31592      +/-   ##
=================================================
- Coverage          49.54%   49.53%   -0.01%     
=================================================
  Files               3322     3329       +7     
  Lines              81748    81831      +83     
  Branches           16874    16888      +14     
=================================================
+ Hits               40501    40538      +37     
- Misses             36509    36542      +33     
- Partials            4738     4751      +13     
Flag Coverage Δ
e2e 53.26% <ø> (+0.02%) ⬆️
e2e-api 40.61% <ø> (-0.04%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Dnouv
Dnouv marked this pull request as ready for review January 31, 2024 19:08
@Dnouv
Dnouv requested a review from a team as a code owner January 31, 2024 19:08
@tassoevan tassoevan added this to the 6.6 milestone Jan 31, 2024
@ggazzo ggazzo changed the title chore: empty attachments leads to a Moderation Console GUI crash regression: empty attachments leads to a Moderation Console GUI crash Jan 31, 2024
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 1, 2024
@kodiakhq
kodiakhq Bot merged commit ead0907 into release-6.6.0 Feb 1, 2024
@kodiakhq
kodiakhq Bot deleted the chore_modc_attachment branch February 1, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants