regression: empty attachments leads to a Moderation Console GUI crash - #31592
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.6.0 #31592 +/- ##
=================================================
- Coverage 49.54% 49.53% -0.01%
=================================================
Files 3322 3329 +7
Lines 81748 81831 +83
Branches 16874 16888 +14
=================================================
+ Hits 40501 40538 +37
- Misses 36509 36542 +33
- Partials 4738 4751 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
Dnouv
marked this pull request as ready for review
January 31, 2024 19:08
tassoevan
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
attachments[]andfiles[]arrays in our message processing logic. Previously, there were edge cases where theattachments[]array was present but empty, and thefiles[]array was not present. This could lead to unexpected behavior. With this update, we've added checks to ensure that theattachments[]array not only exists, but also contains at least one element before attempting to access thefiles[]array. This makes our reported message processing more robust and prevents potential issues caused by these edge cases.Issue(s)
Steps to test or reproduce
Further comments
WM-221