Skip to content

regression: Fix reactions tooltip - #31570

Merged
kodiakhq[bot] merged 1 commit into
release-6.6.0from
reg/reactions
Feb 1, 2024
Merged

regression: Fix reactions tooltip#31570
kodiakhq[bot] merged 1 commit into
release-6.6.0from
reg/reactions

Conversation

@yash-rajpal

@yash-rajpal yash-rajpal commented Jan 29, 2024

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

When reactions hovered for the first time, the tooltip shows "true" for a second before showing actual tooltip

Issue(s)

Closes #31562

Steps to test or reproduce

Further comments

TC-1091
TC-1104

@changeset-bot

changeset-bot Bot commented Jan 29, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 21ca8d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 29, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ebc22c0) 76.47% compared to head (21ca8d0) 49.54%.
Report is 8 commits behind head on release-6.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.6.0   #31570       +/-   ##
==================================================
- Coverage          76.47%   49.54%   -26.94%     
==================================================
  Files                278     3324     +3046     
  Lines               9008    81752    +72744     
  Branches            1708    16875    +15167     
==================================================
+ Hits                6889    40501    +33612     
- Misses              1688    36499    +34811     
- Partials             431     4752     +4321     
Flag Coverage Δ
e2e 53.19% <0.00%> (∅)
e2e-api 40.66% <ø> (?)
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal
yash-rajpal marked this pull request as ready for review January 29, 2024 13:01
@yash-rajpal
yash-rajpal requested a review from a team as a code owner January 29, 2024 13:01
@rique223 rique223 linked an issue Jan 31, 2024 that may be closed by this pull request
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 1, 2024
@kodiakhq
kodiakhq Bot merged commit 7d17f10 into release-6.6.0 Feb 1, 2024
@kodiakhq
kodiakhq Bot deleted the reg/reactions branch February 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unwanted tooltip from reaction emoji

3 participants