Skip to content

chore: change SAML single sign out to access workspace settings directly - #31567

Merged
ggazzo merged 2 commits into
release-6.6.0from
chore/saml-sso-settings
Jan 28, 2024
Merged

chore: change SAML single sign out to access workspace settings directly#31567
ggazzo merged 2 commits into
release-6.6.0from
chore/saml-sso-settings

Conversation

@pierre-lehnen-rc

@pierre-lehnen-rc pierre-lehnen-rc commented Jan 28, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SAML's Single Sign Out feature operated based on the login service configurations data and this data is no longer updated automatically in the client when it changes in the server. This PR changes the single sign out to check the SAML settings directly so it'll always respect the current server configuration.

@changeset-bot

changeset-bot Bot commented Jan 28, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a1b67f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc changed the title chore: change SAML single sign out to access workspace settings direc… chore: change SAML single sign out to access workspace settings directly Jan 28, 2024
@codecov

codecov Bot commented Jan 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8757b3e) 76.47% compared to head (a1b67f7) 49.57%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.6.0   #31567       +/-   ##
==================================================
- Coverage          76.47%   49.57%   -26.90%     
==================================================
  Files                278     3329     +3051     
  Lines               9008    81831    +72823     
  Branches            1708    16888    +15180     
==================================================
+ Hits                6889    40570    +33681     
- Misses              1688    36516    +34828     
- Partials             431     4745     +4314     
Flag Coverage Δ
e2e 53.30% <77.77%> (∅)
e2e-api 40.65% <ø> (?)
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc
pierre-lehnen-rc marked this pull request as ready for review January 28, 2024 19:02
@pierre-lehnen-rc
pierre-lehnen-rc requested a review from a team as a code owner January 28, 2024 19:02
@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.6 milestone Jan 28, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 28, 2024
@ggazzo
ggazzo merged commit 3ec623d into release-6.6.0 Jan 28, 2024
@ggazzo
ggazzo deleted the chore/saml-sso-settings branch January 28, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants