chore: change SAML single sign out to access workspace settings directly - #31567
Merged
Conversation
…tly instead of relying on the login service configuration
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-6.6.0 #31567 +/- ##
==================================================
- Coverage 76.47% 49.57% -26.90%
==================================================
Files 278 3329 +3051
Lines 9008 81831 +72823
Branches 1708 16888 +15180
==================================================
+ Hits 6889 40570 +33681
- Misses 1688 36516 +34828
- Partials 431 4745 +4314
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
marked this pull request as ready for review
January 28, 2024 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SAML's Single Sign Out feature operated based on the login service configurations data and this data is no longer updated automatically in the client when it changes in the server. This PR changes the single sign out to check the SAML settings directly so it'll always respect the current server configuration.