Skip to content

fix: use EJSON serializer for data transfer between multi instances #31540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jan 25, 2024
+20 −2
Merged

fix: use EJSON serializer for data transfer between multi instances #31540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c1653
fix: use EJSON serializer for data transfer between multi instances
sampaiodiego Jan 25, 2024
e67011c
Merge branch 'develop' into fix-multi-instance-data-transfer
kodiakhq[bot] Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-tips-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fix multi-instance data formats being lost
17 changes: 15 additions & 2 deletions apps/meteor/ee/server/local-services/instance/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ import os from 'os';
import { License, ServiceClassInternal } from '@rocket.chat/core-services';
import { InstanceStatus } from '@rocket.chat/instance-status';
import { InstanceStatus as InstanceStatusRaw } from '@rocket.chat/models';
import EJSON from 'ejson';
import type { BrokerNode } from 'moleculer';
import { ServiceBroker, Transporters } from 'moleculer';
import { ServiceBroker, Transporters, Serializers } from 'moleculer';

import { StreamerCentral } from '../../../../server/modules/streamer/streamer.module';
import type { IInstanceService } from '../../sdk/types/IInstanceService';
Expand All @@ -13,6 +14,18 @@ import { getTransporter } from './getTransporter';

const hostIP = process.env.INSTANCE_IP ? String(process.env.INSTANCE_IP).trim() : 'localhost';

const { Base } = Serializers;

class EJSONSerializer extends Base {
serialize(obj: any): Buffer {
return Buffer.from(EJSON.stringify(obj));
}

deserialize(buf: Buffer): any {
return EJSON.parse(buf.toString());
}
}

export class InstanceService extends ServiceClassInternal implements IInstanceService {
protected name = 'instance';

Expand Down Expand Up @@ -83,7 +96,7 @@ export class InstanceService extends ServiceClassInternal implements IInstanceSe
this.broker = new ServiceBroker({
nodeID: InstanceStatus.id(),
transporter: this.transporter,

serializer: new EJSONSerializer(),
...getLogger(process.env),
});

Expand Down