fix: webclient still showing DM messages that had already been deleted from the server - #31537
Merged
Merged
Conversation
…d from the server
🦋 Changeset detectedLatest commit: 6a3fc84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31537 +/- ##
===========================================
- Coverage 49.57% 49.54% -0.03%
===========================================
Files 3328 3328
Lines 81793 81771 -22
Branches 16881 16877 -4
===========================================
- Hits 40546 40511 -35
- Misses 36503 36514 +11
- Partials 4744 4746 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
Bot
added
the
stat: ready to merge
gabriellsh
approved these changes
Jan 25, 2024
dionisio-bot
Bot
added
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
When a room is deleted in the server, the webclient does not clear its cache of that room's history.
If a new room is created with the same ID as the deleted room, the client would still show those cached messages from the deleted room in the new room - it also failed to properly send and load new messages to this new room until the user refreshed the window.
This is only possible on basic DMs, where the room id is not random but calculated based on the ids of the users involved.
Steps to test or reproduce
Further comments