fix: update SHIFT+ESCAPE handler for consistent clear unread modal display - #31432
Merged
Conversation
🦋 Changeset detectedLatest commit: 22ce63a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31432 +/- ##
========================================
Coverage 49.56% 49.57%
========================================
Files 3313 3316 +3
Lines 81477 81514 +37
Branches 16709 16716 +7
========================================
+ Hits 40386 40411 +25
- Misses 36393 36398 +5
- Partials 4698 4705 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
abhinavkrin
marked this pull request as ready for review
January 12, 2024 16:38
yash-rajpal
approved these changes
Jan 12, 2024
yash-rajpal
left a comment
yash-rajpal
left a comment
Member
There was a problem hiding this comment.
LGTM!!
Congratulations on your first PR as a rocketeer. 🚀
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR addresses the issue with the SHIFT+ESCAPE shortcut in Rocket.Chat. The shortcut was not consistently triggering the unread messages clearing modal. The fix ensures consistent functionality across different states of unread messages and browsers.
Issue(s)
SHIFT+ESCAPE not always clears all unread messages and loading task manager instead
Steps to test or reproduce
Further comments
SUP-222