Skip to content

fix: Disable quote avatars according to user preference - #31393

Merged
kodiakhq[bot] merged 6 commits into
RocketChat:developfrom
rezerov:fix/QuoteAvatars
Jan 8, 2024
Merged

fix: Disable quote avatars according to user preference#31393
kodiakhq[bot] merged 6 commits into
RocketChat:developfrom
rezerov:fix/QuoteAvatars

Conversation

@rezerov

@rezerov rezerov commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

This PR aims to resolve the issue where disabling avatars in user preferences does not disable them in quoted messages.

Before:
image

After:
image
image

After re-enabling the avatars in message preferences, it looks unchanged

image

Issue(s)

fixes #30709

Steps to test or reproduce

  1. Disable avatars in Account -> Preferences -> Messages -> Display Avatars
  2. Write a message.
  3. Write a second message quoting the first one.

Further comments

@rezerov
rezerov requested a review from a team as a code owner January 7, 2024 11:19
@changeset-bot

changeset-bot Bot commented Jan 7, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e579b76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jan 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9564a4) 49.47% compared to head (e579b76) 49.48%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31393   +/-   ##
========================================
  Coverage    49.47%   49.48%           
========================================
  Files         3312     3312           
  Lines        81367    81369    +2     
  Branches     16657    16658    +1     
========================================
+ Hits         40259    40268    +9     
+ Misses       36405    36397    -8     
- Partials      4703     4704    +1     
Flag Coverage Δ
e2e 52.88% <100.00%> (+0.02%) ⬆️
e2e-api 40.69% <ø> (ø)
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rezerov rezerov changed the title fix: quote attachments now use preference for avatars fix: Disable quote avatars according to user preference Jan 7, 2024
@dougfabris dougfabris added this to the 6.6 milestone Jan 8, 2024

@dougfabris dougfabris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 8, 2024
@kodiakhq
kodiakhq Bot merged commit d6165ad into RocketChat:develop Jan 8, 2024
@rezerov
rezerov deleted the fix/QuoteAvatars branch January 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

Development

Successfully merging this pull request may close these issues.

Disabling message avatars doesn't disable them in quotes

2 participants