fix: Disable quote avatars according to user preference - #31393
Merged
Conversation
🦋 Changeset detectedLatest commit: e579b76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31393 +/- ##
========================================
Coverage 49.47% 49.48%
========================================
Files 3312 3312
Lines 81367 81369 +2
Branches 16657 16658 +1
========================================
+ Hits 40259 40268 +9
+ Misses 36405 36397 -8
- Partials 4703 4704 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR aims to resolve the issue where disabling avatars in user preferences does not disable them in quoted messages.
Before:

After:


After re-enabling the avatars in message preferences, it looks unchanged
Issue(s)
fixes #30709
Steps to test or reproduce
Further comments