fix: LDAP Group filter doesn't work and throws "No Such Object" error on login - #31377
Merged
Conversation
🦋 Changeset detectedLatest commit: a47635c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31377 +/- ##
===========================================
- Coverage 49.60% 49.56% -0.04%
===========================================
Files 3308 3312 +4
Lines 81389 81460 +71
Branches 16697 16712 +15
===========================================
+ Hits 40370 40379 +9
- Misses 36328 36370 +42
- Partials 4691 4711 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
requested changes
Jan 9, 2024
pierre-lehnen-rc
left a comment
Contributor
There was a problem hiding this comment.
Instead of creating a new connection, just validate the group before validating the password.
pierre-lehnen-rc
approved these changes
Jan 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Fixes #15621
Fixes #15069
Steps to test or reproduce
Further comments
TC-1073