Skip to content

fix: typo error in livechat.applySimultaneousChatRestrictions hook - #31198

Merged
kodiakhq[bot] merged 2 commits into
RocketChat:developfrom
mahyarkarimi:fix/applySimultaneousChatRestrictions
Dec 11, 2023
Merged

fix: typo error in livechat.applySimultaneousChatRestrictions hook#31198
kodiakhq[bot] merged 2 commits into
RocketChat:developfrom
mahyarkarimi:fix/applySimultaneousChatRestrictions

Conversation

@mahyarkarimi

Copy link
Copy Markdown
Contributor

fix: fixed typo error of livechat.applySimultaneousChatRestrictions in livechat-enterprise to apply department simultaneous chat restriction.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@mahyarkarimi
mahyarkarimi requested a review from a team as a code owner December 9, 2023 11:31
@changeset-bot

changeset-bot Bot commented Dec 9, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 26ceb0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 11, 2023
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 11, 2023
@codecov

codecov Bot commented Dec 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31198 (26ceb0f) into develop (e407017) will decrease coverage by 9.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31198      +/-   ##
===========================================
- Coverage    57.88%   48.86%   -9.02%     
===========================================
  Files          886     3272    +2386     
  Lines        20290    80358   +60068     
  Branches      3783    16381   +12598     
===========================================
+ Hits         11744    39267   +27523     
- Misses        7845    36438   +28593     
- Partials       701     4653    +3952     
Flag Coverage Δ
e2e 51.30% <ø> (+8.93%) ⬆️
e2e-api 40.66% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq
kodiakhq Bot merged commit 9d1f4f8 into RocketChat:develop Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants