Skip to content

fix: Registration Data - #31185

Merged
ggazzo merged 2 commits into
developfrom
fix/registration
Dec 11, 2023
Merged

fix: Registration Data#31185
ggazzo merged 2 commits into
developfrom
fix/registration

Conversation

@ggazzo

@ggazzo ggazzo commented Dec 7, 2023

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Dec 7, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 44bb172

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Dec 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31185 (44bb172) into develop (0e8e2e5) will decrease coverage by 8.98%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31185      +/-   ##
===========================================
- Coverage    57.89%   48.92%   -8.98%     
===========================================
  Files          886     3272    +2386     
  Lines        20299    80347   +60048     
  Branches      3783    16333   +12550     
===========================================
+ Hits         11753    39309   +27556     
- Misses        7845    36416   +28571     
- Partials       701     4622    +3921     
Flag Coverage Δ
e2e 51.34% <ø> (+8.97%) ⬆️
e2e-api 40.73% <ø> (?)
unit 77.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
ggazzo marked this pull request as ready for review December 7, 2023 18:08
@ggazzo
ggazzo requested review from a team as code owners December 7, 2023 18:08
@ggazzo ggazzo added this to the 6.5.1 milestone Dec 7, 2023
Comment thread apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
Comment thread apps/meteor/server/settings/general.ts
Comment thread apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
@ggazzo
ggazzo merged commit e407017 into develop Dec 11, 2023
@ggazzo
ggazzo deleted the fix/registration branch December 11, 2023 12:53
ggazzo added a commit that referenced this pull request Dec 11, 2023
@rodrigok rodrigok modified the milestones: 6.5.1, 6.6 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants