-
Notifications
You must be signed in to change notification settings - Fork 13.9k
feat(uikit): Move @rocket.chat/ui-kit package to the main monorepo
#31138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c30870e
Add `@rocket.chat/ui-kit`
tassoevan b79b0a8
Fix references to UiKit types
tassoevan 827c97c
Add changeset
tassoevan 4f803c9
Fix lint issue
tassoevan 12d5d0c
Tweak `Dockerfile`s
tassoevan 70f190d
Explicitly add `typia` dependency
tassoevan e9a0aaa
Merge branch 'develop' into feat/uikit-package
tiagoevanp 5d703ea
Patch release action
tassoevan bdb1f68
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
tassoevan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| --- | ||
| '@rocket.chat/ui-kit': minor | ||
| '@rocket.chat/server-cloud-communication': patch | ||
| '@rocket.chat/omnichannel-services': patch | ||
| 'rocketchat-services': patch | ||
| '@rocket.chat/omnichannel-transcript': patch | ||
| '@rocket.chat/authorization-service': patch | ||
| '@rocket.chat/web-ui-registration': patch | ||
| '@rocket.chat/stream-hub-service': patch | ||
| '@rocket.chat/password-policies': patch | ||
| '@rocket.chat/uikit-playground': patch | ||
| '@rocket.chat/presence-service': patch | ||
| '@rocket.chat/fuselage-ui-kit': patch | ||
| '@rocket.chat/instance-status': patch | ||
| '@rocket.chat/account-service': patch | ||
| '@rocket.chat/mock-providers': patch | ||
| '@rocket.chat/release-action': patch | ||
| '@rocket.chat/api-client': patch | ||
| '@rocket.chat/ddp-client': patch | ||
| '@rocket.chat/pdf-worker': patch | ||
| '@rocket.chat/ui-theming': patch | ||
| '@rocket.chat/account-utils': patch | ||
| '@rocket.chat/core-services': patch | ||
| '@rocket.chat/eslint-config': patch | ||
| '@rocket.chat/model-typings': patch | ||
| '@rocket.chat/ui-video-conf': patch | ||
| '@rocket.chat/cas-validate': patch | ||
| '@rocket.chat/core-typings': patch | ||
| '@rocket.chat/rest-typings': patch | ||
| '@rocket.chat/server-fetch': patch | ||
| '@rocket.chat/ddp-streamer': patch | ||
| '@rocket.chat/queue-worker': patch | ||
| '@rocket.chat/presence': patch | ||
| '@rocket.chat/poplib': patch | ||
| '@rocket.chat/ui-composer': patch | ||
| '@rocket.chat/ui-contexts': patch | ||
| '@rocket.chat/license': patch | ||
| '@rocket.chat/log-format': patch | ||
| '@rocket.chat/gazzodown': patch | ||
| '@rocket.chat/ui-client': patch | ||
| '@rocket.chat/livechat': patch | ||
| '@rocket.chat/favicon': patch | ||
| '@rocket.chat/agenda': patch | ||
| '@rocket.chat/base64': patch | ||
| '@rocket.chat/logger': patch | ||
| '@rocket.chat/models': patch | ||
| '@rocket.chat/random': patch | ||
| '@rocket.chat/sha256': patch | ||
| '@rocket.chat/tools': patch | ||
| '@rocket.chat/cron': patch | ||
| '@rocket.chat/i18n': patch | ||
| '@rocket.chat/jwt': patch | ||
| '@rocket.chat/meteor': patch | ||
| --- | ||
|
|
||
| feat(uikit): Move `@rocket.chat/ui-kit` package to the main monorepo |
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any special reason to use
workspace:~instead ofworkspace:^? this used to be an issue with the script to fix the version dependencies before publishing a package, but now we just ignore whatever "symbol" is being used..so my question is more why did you chose for
~? since we use^for everything elseUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I particularly go for
yarn add --tildewhen adding new dependency because "tilde-dependencies" deny minor-version bumps, while carets not; in my personal projects, I even putdefaultSemverRangePrefix: "~"on.yarnrc.yml.When the package is published on npmjs registry,
workspace:~is replaced with~x.y.zwhileworkspace:^is replaced with^x.y.z.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, we always set to
^x.y.z:Rocket.Chat/packages/release-action/src/fixWorkspaceVersionsBeforePublish.ts
Line 49 in 05f45dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we shouldn't have to do this heavy-lifting ourselves... https://yarnpkg.com/features/workspaces#cross-references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Na prática, a teoria é outra."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patched the action's code.