Skip to content

fix: purge messageBox related items from localstorage on logout #31104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Dec 1, 2023
Merged

fix: purge messageBox related items from localstorage on logout #31104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86862c8
use correct storageId and localStorage
yash-rajpal Nov 29, 2023
b0c2f3b
add changeset
yash-rajpal Nov 29, 2023
dbf488c
Merge branch 'develop' into fix/remove-messageBox-logout
kodiakhq[bot] Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brown-ads-tell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Clear message box related items from local storage on logout
4 changes: 2 additions & 2 deletions apps/meteor/client/startup/afterLogoutCleanUp/purgeAllDrafts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { afterLogoutCleanUpCallback } from '../../../lib/callbacks/afterLogoutCl

Meteor.startup(() => {
const purgeAllDrafts = (): void => {
Object.keys(Meteor._localStorage)
Object.keys(localStorage)
.filter((key) => key.indexOf('messagebox_') === 0)
.forEach((key) => Meteor._localStorage.removeItem(key));
.forEach((key) => localStorage.removeItem(key));
};

afterLogoutCleanUpCallback.add(purgeAllDrafts, callbacks.priority.MEDIUM, 'chatMessages-after-logout-cleanup');
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const MessageBox = ({
const messageComposerRef = useRef<HTMLElement>(null);
const shadowRef = useRef(null);

const storageID = `${room._id}${tmid ? `-${tmid}` : ''}`;
const storageID = `messagebox_${room._id}${tmid ? `-${tmid}` : ''}`;

const callbackRef = useCallback(
(node: HTMLTextAreaElement) => {
Expand Down