Skip to content

fix: mention channel redirecting to own DM - #31099

Merged
kodiakhq[bot] merged 3 commits into
developfrom
fix/dm-mention-channel
Nov 30, 2023
Merged

fix: mention channel redirecting to own DM#31099
kodiakhq[bot] merged 3 commits into
developfrom
fix/dm-mention-channel

Conversation

@guijun13

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  1. Create a channel
  2. Open a dm with another user
  3. Mention the channel you have created, e.g: #channel
  4. Click on the mention

Further comments

https://rocketchat.atlassian.net/browse/TC-1017

@changeset-bot

changeset-bot Bot commented Nov 28, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a26512d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31099 (a26512d) into develop (157f8f4) will decrease coverage by 1.43%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31099      +/-   ##
===========================================
- Coverage    56.72%   55.29%   -1.43%     
===========================================
  Files          883     1585     +702     
  Lines        19990    31120   +11130     
  Branches      3689     6309    +2620     
===========================================
+ Hits         11340    17209    +5869     
- Misses        7956    12565    +4609     
- Partials       694     1346     +652     
Flag Coverage Δ
e2e 47.03% <0.00%> (+4.64%) ⬆️
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal
yash-rajpal marked this pull request as ready for review November 29, 2023 13:32
@yash-rajpal
yash-rajpal requested a review from a team as a code owner November 29, 2023 13:32
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 30, 2023
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 30, 2023
@kodiakhq
kodiakhq Bot merged commit d71876c into develop Nov 30, 2023
@kodiakhq
kodiakhq Bot deleted the fix/dm-mention-channel branch November 30, 2023 13:08
@scuciatto scuciatto added this to the 6.6 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants