Skip to content

fix: UnhandledPromiseRejection on PUT livechat/departments/:_id endpoint - #31049

Merged
kodiakhq[bot] merged 5 commits into
developfrom
fix/put-departments-missing-promise
Nov 22, 2023
Merged

fix: UnhandledPromiseRejection on PUT livechat/departments/:_id endpoint#31049
kodiakhq[bot] merged 5 commits into
developfrom
fix/put-departments-missing-promise

Conversation

@KevLehman

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Nov 22, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3ab8dda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31049 (3ab8dda) into develop (93b876d) will increase coverage by 4.86%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31049      +/-   ##
===========================================
+ Coverage    46.32%   51.18%   +4.86%     
===========================================
  Files          766      807      +41     
  Lines        14676    15139     +463     
  Branches      2753     2819      +66     
===========================================
+ Hits          6798     7749     +951     
+ Misses        7479     6957     -522     
- Partials       399      433      +34     
Flag Coverage Δ
e2e 48.09% <ø> (+5.69%) ⬆️
unit 66.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 22, 2023
@KevLehman KevLehman added stat: needs QA and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 22, 2023
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 22, 2023
@KevLehman
KevLehman marked this pull request as ready for review November 22, 2023 18:00
@KevLehman
KevLehman requested review from a team as code owners November 22, 2023 18:00
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 22, 2023
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Nov 22, 2023
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 22, 2023
@kodiakhq
kodiakhq Bot merged commit f340139 into develop Nov 22, 2023
@kodiakhq
kodiakhq Bot deleted the fix/put-departments-missing-promise branch November 22, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants