fix: initial stuck client if root_url is wrong - #30913
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #30913 +/- ##
===========================================
- Coverage 57.77% 48.88% -8.90%
===========================================
Files 885 3272 +2387
Lines 20228 80283 +60055
Branches 3766 16318 +12552
===========================================
+ Hits 11687 39246 +27559
- Misses 7848 36422 +28574
- Partials 693 4615 +3922
Flags with carried forward coverage won't be shown. Click here to find out more. |
geekgonecrazy
left a comment
There was a problem hiding this comment.
This is extremely disruptive to brand new deployments.
Our 1-click installation images are all affected by this. Because you can't access them with your browser at localhost but Rocket.Chat by default has localhost on root_url and site url
So they'll access at the public ip and it's broken. Very bad first impression
|
Hello, I still have the 3 dots after the update. It's a clean environment. I tested a lot with the ROOT_URL variable and also tested in MongoDB with the SITE_URL for examble: I can rotate it however I want, the 3 dots remain. Another idea what I can test? |
closes #30990
closes #30931
closes #31169
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments