fix: Atlassian Crowd authorization

[paulloft]

Fixed broken Atlassian Crowd login after these changes

Issue(s)

Fixes #29285

[changeset-bot]

⚠️ No Changeset found

Latest commit: 53dc23c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

paulloft seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[pdjshog]

thx helped

[Nezisi]

Thanks alot, @paulloft .

I built a patched release of the 6.4.5 tag with the two commits applied, then ran a test deployment.

Worked perfectly.

Fixed all errors, crowd login works and tested a bit the crowd administration page - synchronization / ping worked, too.

Rolled the patched 6.4.5 release out for production, as I couldn't find any issues.

:-) 👍

[Nezisi]

@paulloft

I'm not sure if the bug was introduced by this patch, but we found a very severe bug:

If a user logins for the first time, the synchronization process overwrites erroneously an existing user with crowd data.

E.g. user "alice.wonderland" logs in, user isn't found in the local RocketChat MongoDB database, then crowd user is fetched and a new account should be generated.

Instead the whole account data of another user, like "bob.builder" is overwritten with the fetched crowd user data.

Redacted logging output:

{"level":30,"name":"CROWD","msg":"Init CROWD login 'alice.wonderland'"}
{"level":30,"name":"CROWD","msg":"Extracting crowd_username"}
{"level":20,"name":"CROWD","msg":"Could not find a user by username"}
{"level":20,"name":"CROWD","msg":"Could not find a user with by crowd_username 'alice.wonderland'"}
{"level":20,"name":"CROWD","msg":"New user. User is not synced yet."}
{"level":20,"name":"CROWD","msg":"Going to crowd: 'alice.wonderland'"}

If I'm not mistaken, the error should be somewhere in the async updateUserCollection(crowdUser: Record<string, any>) function :

Rocket.Chat/apps/meteor/app/crowd/server/crowd.ts

Line 263 in 53dc23c

async updateUserCollection(crowdUser: Record<string, any>) {

[dougfabris]

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's stale now and it was already fixed here: #31391

---

Questions? Help needed? Feature Requests?

• Join our Open Server in the #support channel and feel free to raise a question
• Join our Community Forum and search/create a post there