fix: Message mentions displayed in the UI are outdated after changing username - #30625
Closed
matheusbsilva137 wants to merge 2 commits into
Closed
fix: Message mentions displayed in the UI are outdated after changing username#30625matheusbsilva137 wants to merge 2 commits into
matheusbsilva137 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 815a146 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30625 +/- ##
===========================================
- Coverage 51.28% 51.24% -0.05%
===========================================
Files 811 809 -2
Lines 15078 15140 +62
Branches 2754 2775 +21
===========================================
+ Hits 7733 7758 +25
- Misses 6935 6954 +19
- Partials 410 428 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
requested changes
Oct 12, 2023
yash-rajpal
left a comment
yash-rajpal
left a comment
Member
There was a problem hiding this comment.
Shouldn't we parse the newMessage and update the md property?
Contributor
Author
|
Handled in #31860 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
md) field when updating messages that mention the username changed (so that the client tries to parse it again with the updated content).Issue(s)
Steps to test or reproduce
Further comments
SUP-378