Skip to content

chore: make delete user method keep working without relying on msg db watcher - #30435

Merged
MarcosSpessatto merged 6 commits into
chore/remove-message-db-watcher-1from
chore/adapt-delete-user-without-message-watcher
Nov 10, 2023
Merged

chore: make delete user method keep working without relying on msg db watcher#30435
MarcosSpessatto merged 6 commits into
chore/remove-message-db-watcher-1from
chore/adapt-delete-user-without-message-watcher

Conversation

@MarcosSpessatto

@MarcosSpessatto MarcosSpessatto commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

ARCH-1214

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Sep 18, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c2515ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Sep 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #30435 (c2515ab) into chore/remove-message-db-watcher-1 (62a7f29) will decrease coverage by 2.72%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           chore/remove-message-db-watcher-1   #30435      +/-   ##
=====================================================================
- Coverage                              49.93%   47.21%   -2.72%     
=====================================================================
  Files                                    784      807      +23     
  Lines                                  14973    15051      +78     
  Branches                                2794     2818      +24     
=====================================================================
- Hits                                    7477     7107     -370     
- Misses                                  7072     7513     +441     
- Partials                                 424      431       +7     
Flag Coverage Δ
e2e 43.57% <33.33%> (-3.14%) ⬇️
unit 65.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto changed the title chore: make delete user method working without relying on msg db watcher chore: make delete user method keep working without relying on msg db watcher Sep 21, 2023
@MarcosSpessatto
MarcosSpessatto marked this pull request as ready for review November 3, 2023 19:32
@MarcosSpessatto
MarcosSpessatto requested review from a team as code owners November 3, 2023 19:32
Marcos Spessatto Defendi added 2 commits November 10, 2023 16:43
@MarcosSpessatto
MarcosSpessatto merged commit 040c1af into chore/remove-message-db-watcher-1 Nov 10, 2023
@MarcosSpessatto
MarcosSpessatto deleted the chore/adapt-delete-user-without-message-watcher branch November 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants