refactor: Move channel related props outside of room.visitor #29791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #29791 +/- ##
============================================
+ Coverage 31.06% 47.89% +16.82%
============================================
Files 560 691 +131
Lines 10808 13007 +2199
Branches 2007 2290 +283
============================================
+ Hits 3358 6230 +2872
+ Misses 7245 6434 -811
- Partials 205 343 +138
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
changed the title
(cherry picked from commit 9dd14b2)
KevLehman
previously approved these changes
Jul 13, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
KevLehman
previously approved these changes
Jul 24, 2023
d-gubert
previously approved these changes
Jul 25, 2023
Member
|
@RocketChat/architecture your review is requested as Code Owner, likely due to the update of Apps-Engine version in several packages |
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
KevLehman
approved these changes
Aug 10, 2023
d-gubert
approved these changes
Aug 10, 2023
sampaiodiego
approved these changes
Aug 21, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 23, 2023
…unreadMark * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) test: Personal tokens flaky 2 (#30147) fix: Livechat message fetching method in LivechatBridge (#30000) fix: Users shouldn't be able to transfer rooms to departments with no online agents (#30065) test: Personal tokens flaky (#30140) regression: Change user preference value when feature preview are not enabled (#30135) feat: Delete read receipts on messages deletion (#29720) chore: move logger to a separate package (#30092) refactor: Deprecate transcript & triggers endpoints and create tests (#29861) fix: Use correct `mediaTypeWhitelist `instead of wrong func on SMS providers (#29706) fix: Agent count not updating after removing agents (#29871) feat: Accessibility Activation (#29958) fix: put actual user status on omnichannel queue view (#29844) fix: User Mentioning when prepending the username with > (#28875) feat: add support for threads in federated rooms (#29655) fix: Trigger app post user created event correctly (#30006) feat: apply group filter to LDAP sync process (#30088) fix: slackbridge was not receiving updates from Slack events anymore (#29592) feat: Report User (#29818) refactor: Move channel related props outside of room.visitor (#29791) fix: HTTP timeout too short on Apps-Engine bridge (#30129) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Over here #29756 , we updated the app's bridge to include channel related props on visitor level on apps. Doug had some feedback on this approach and he suggested that instead of merging channel and visitor level props, we should try to keep then separate, and that's exactly what we're doing here :)
Issue(s)
Steps to test or reproduce
Further comments
Corresponding Apps-engine PR with the type changes -> RocketChat/Rocket.Chat.Apps-engine#645