Skip to content

Conversation

@dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris force-pushed the chore/buttonGroup-prop branch 2 times, most recently from 60ecec9 to f10150e Compare January 19, 2023 02:09
juliajforesti
juliajforesti previously approved these changes Jan 19, 2023
@dougfabris dougfabris force-pushed the chore/buttonGroup-prop branch from aa35e23 to 1cafa32 Compare January 19, 2023 23:52
@dougfabris dougfabris marked this pull request as ready for review January 20, 2023 00:06
@dougfabris dougfabris requested a review from a team as a code owner January 20, 2023 00:06
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #27784 (1cafa32) into develop (6bd0627) will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27784      +/-   ##
===========================================
+ Coverage    42.03%   42.96%   +0.92%     
===========================================
  Files          845      818      -27     
  Lines        17783    17266     -517     
  Branches      2019     1944      -75     
===========================================
- Hits          7475     7418      -57     
+ Misses       10043     9583     -460     
  Partials       265      265              
Flag Coverage Δ
e2e 42.96% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit c1142a5 into develop Jan 20, 2023
@kodiakhq kodiakhq bot deleted the chore/buttonGroup-prop branch January 20, 2023 03:22
gabriellsh added a commit that referenced this pull request Jan 23, 2023
…etChat/Rocket.Chat into matrixSearch

* 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat:
  Chore: Move service shutdown logic to each service (#27690)
  Chore: change colors to dark theme on Marketplace (#27532)
  Chore: Update color tokens (#27704)
  Chore: Remove medium prop from ButtonGroup  (#27784)
  Regression: Add support for 2FA errors to `Meteor.callAsync` (#27767)
  [NEW] Attachment Files Redesign (#27470)
  [FIX] App page showing version undefined for apps not in marketplace (#27766)
  Chore: Add surface-light background to AppRow (#27765)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants