Chore: change colors to dark theme on Marketplace #27532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27532 +/- ##
===========================================
+ Coverage 41.87% 42.89% +1.02%
===========================================
Files 845 818 -27
Lines 17783 17266 -517
Branches 2019 1944 -75
===========================================
- Hits 7447 7407 -40
+ Misses 10073 9595 -478
- Partials 263 264 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheuslc
reviewed
Jan 2, 2023
apps/meteor/client/views/admin/apps/AppDetailsPage/AppDetailsPageHeader.tsx
Outdated
Show resolved
Hide resolved
dougfabris
requested changes
Jan 10, 2023
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
@felipe-rod123 adding color='default' once on the top level Box in each file is enough
juliajforesti
approved these changes
Jan 16, 2023
dougfabris
approved these changes
Jan 19, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: Chore: Move service shutdown logic to each service (#27690) Chore: change colors to dark theme on Marketplace (#27532) Chore: Update color tokens (#27704) Chore: Remove medium prop from ButtonGroup (#27784) Regression: Add support for 2FA errors to `Meteor.callAsync` (#27767) [NEW] Attachment Files Redesign (#27470) [FIX] App page showing version undefined for apps not in marketplace (#27766) Chore: Add surface-light background to AppRow (#27765)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed some bugs on the new dark theme in the Marketplace page. The new version looks like this now:
Issue(s)
Steps to test or reproduce
Go to the Marketplace Apps Page:
Further comments