Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 12, 2023

Proposed changes (including videos or screenshots)

It should fixes crashes on starred, pinned, and mentioned messages while those are migrating from Blaze to React.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan force-pushed the regression/missing-contexts-on-contextual-bar branch from f5c603c to 294b405 Compare January 12, 2023 14:00
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #27734 (bf15fb6) into develop (f5f5bf8) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27734      +/-   ##
===========================================
+ Coverage    41.31%   41.57%   +0.25%     
===========================================
  Files          841      841              
  Lines        17706    17706              
  Branches      1996     1996              
===========================================
+ Hits          7315     7361      +46     
+ Misses       10154    10103      -51     
- Partials       237      242       +5     
Flag Coverage Δ
e2e 41.57% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review January 12, 2023 15:41
@tassoevan tassoevan requested a review from a team as a code owner January 12, 2023 15:41
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 12, 2023
@tassoevan tassoevan added this to the 6.0.0 milestone Jan 12, 2023
@kodiakhq kodiakhq bot merged commit 3a1f7e0 into develop Jan 12, 2023
@kodiakhq kodiakhq bot deleted the regression/missing-contexts-on-contextual-bar branch January 12, 2023 17:36
gabriellsh added a commit that referenced this pull request Jan 16, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Show different labels based on the call originator on direct calls (#27729)
  Chore: Change bundle tags color and refactor app details page header styles (#27293)
  [FIX] Auto Translate not working on new message template (#27317)
  Chore: Custom Sounds Empty State (#27632)
  [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556)
  Regression: Broken room and message composer events (#27754)
  [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699)
  [IMPROVE] SAML and OAuth role sync to support id and name (#27405)
  Chore: add e2e test coverage for Video Conference (#27075)
  Chore: Invites Empty State (#27631)
  [FIX] Marketplace app status initially disabled (#27330)
  Regression: Missing contexts on contextual bar (#27734)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants