Skip to content

Conversation

@dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

It also replace useEndpointData in favor of useQuery

before

Screen Shot 2022-12-23 at 17 32 35

after

Screen Shot 2022-12-23 at 17 31 50

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner December 23, 2022 20:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #27632 (499147e) into develop (0c53e9d) will increase coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 499147e differs from pull request most recent head 57d1139. Consider uploading reports for the commit 57d1139 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27632      +/-   ##
===========================================
+ Coverage    41.97%   42.28%   +0.31%     
===========================================
  Files          841      813      -28     
  Lines        17706    17182     -524     
  Branches      1996     1920      -76     
===========================================
- Hits          7432     7266     -166     
+ Misses       10016     9678     -338     
+ Partials       258      238      -20     
Flag Coverage Δ
e2e 42.28% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the title Chore: Add Custom Sounds Empty State Chore: Custom Sounds Empty State Dec 26, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 9, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 9, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Jan 9, 2023
@kodiakhq kodiakhq bot merged commit 69c7248 into develop Jan 16, 2023
@kodiakhq kodiakhq bot deleted the chore/customSounds-empty-state branch January 16, 2023 14:42
gabriellsh added a commit that referenced this pull request Jan 16, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Show different labels based on the call originator on direct calls (#27729)
  Chore: Change bundle tags color and refactor app details page header styles (#27293)
  [FIX] Auto Translate not working on new message template (#27317)
  Chore: Custom Sounds Empty State (#27632)
  [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556)
  Regression: Broken room and message composer events (#27754)
  [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699)
  [IMPROVE] SAML and OAuth role sync to support id and name (#27405)
  Chore: add e2e test coverage for Video Conference (#27075)
  Chore: Invites Empty State (#27631)
  [FIX] Marketplace app status initially disabled (#27330)
  Regression: Missing contexts on contextual bar (#27734)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants