[NEW] Apple Login #24060
Merged
[NEW] Apple Login #24060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
force-pushed
the
feat/apple-oauth
branch
3 times, most recently
from
19f1fbb
to
93e2f4a
Compare
ggazzo
force-pushed
the
feat/apple-oauth
branch
from
93e2f4a
to
ef7abf2
Compare
|
|
jeanfbrito
previously approved these changes
Jan 12, 2022
sampaiodiego
requested changes
Jan 12, 2022
Co-authored-by: Diego Sampaio <[email protected]>
| showButton: false, | ||
| secret, | ||
| enabled: settings.get('Accounts_OAuth_Apple'), | ||
| loginStyle: 'redirect', |
There was a problem hiding this comment.
should this just use config.loginStyle instead of having duplicated here?
| scope: 'name email', | ||
| mergeUsers: true, | ||
| accessTokenParam: 'access_token', | ||
| loginStyle: 'redirect', |
There was a problem hiding this comment.
should we use 'popup' instead? I remember we discussing how 'redirect' could be bad for the desktop app.
There was a problem hiding this comment.
I dont think this has any effect since we trigger the action by the apple script
but sure its a little messed
sampaiodiego
requested changes
Jan 12, 2022
| export const AppleOauthButton: FC = () => { | ||
| const enabled = useSetting('Accounts_OAuth_Apple'); | ||
| const absoluteUrl = useAbsoluteUrl(); | ||
| const appleClientID = useSetting('Accounts_OAuth_Apple_id') || '[CLIENT_ID]'; |
There was a problem hiding this comment.
Suggested change
| const appleClientID = useSetting('Accounts_OAuth_Apple_id') || '[CLIENT_ID]'; | |
| const appleClientID = useSetting('Accounts_OAuth_Apple_id'); |
sampaiodiego
approved these changes
Jan 14, 2022
gabriellsh
added a commit
that referenced
this pull request
Jan 17, 2022
…ove/setup-wizard * 'develop' of github.com:RocketChat/Rocket.Chat: (176 commits) [IMPROVE] Admin page header buttons consistency (#24168) i18n: Language update from LingoHub 🤖 on 2022-01-17Z (#24193) [FIX] Integration section crashing opening in My Account (#24068) [IMPROVE] Rewrite roomNotFound to React Component (#24044) Regression: Enable custom emoji on admin custom status page (#24186) Chore: Update Meteor to 2.5.3 (#24075) [NEW] Apple Login (#24060) Chore: Update Apps-Engine to 1.29.2 (#24171) feat: enabling emoji on custom status (#24170) [FIX] App Framework Enable hanging indefinitely (#24158) [FIX] CSV Importer failing to import users (#24090) Fix Engagement Dashboard API requests (#24142) Language update from LingoHub 🤖 (#24127) Chore: Migrate useOutsideClick to fuselage-hooks (#24133) Revert "Use fibers to store context" Use fibers to store context Chore: Include REG_TOKEN in docker-compose (#24123) [FIX] Custom Emoji Image preview #24117 [IMPROVE] Added a Reset Button in the Account Profile Page (#24078) Revert: "[IMPROVE] Throw 404 error in invalid endpoints" (#24118) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments