Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Rewrite roomNotFound to React Component #24044

Merged
merged 11 commits into from
Jan 16, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 28, 2021

Proposed changes (including videos or screenshots)

before

image
image

after

image
image

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris changed the title [IMPROVE]: Rewrite roomNotFound to React Component [IMPROVE] Rewrite roomNotFound to React Component Dec 28, 2021
@dougfabris dougfabris requested a review from a team December 28, 2021 21:32
@ggazzo
Copy link
Member

ggazzo commented Dec 29, 2021

check the variation='danger'

app/ui-utils/client/lib/openRoom.js Outdated Show resolved Hide resolved
client/views/room/Room/RoomNotFound/RoomNotFound.tsx Outdated Show resolved Hide resolved
@dougfabris dougfabris added this to the 4.4.0 milestone Jan 12, 2022
@dougfabris dougfabris merged commit 178ed82 into develop Jan 16, 2022
@dougfabris dougfabris deleted the improve/roomNotFound branch January 16, 2022 21:38
gabriellsh added a commit that referenced this pull request Jan 17, 2022
…ove/setup-wizard

* 'develop' of github.com:RocketChat/Rocket.Chat: (176 commits)
  [IMPROVE] Admin page header buttons consistency (#24168)
  i18n: Language update from LingoHub 🤖 on 2022-01-17Z (#24193)
  [FIX] Integration section crashing opening in My Account (#24068)
  [IMPROVE] Rewrite roomNotFound to React Component (#24044)
  Regression: Enable custom emoji on admin custom status page (#24186)
  Chore: Update Meteor to 2.5.3 (#24075)
  [NEW] Apple Login (#24060)
  Chore: Update Apps-Engine to 1.29.2 (#24171)
  feat: enabling emoji on custom status (#24170)
  [FIX] App Framework Enable hanging indefinitely (#24158)
  [FIX] CSV Importer failing to import users (#24090)
  Fix Engagement Dashboard API requests (#24142)
  Language update from LingoHub 🤖 (#24127)
  Chore: Migrate useOutsideClick to fuselage-hooks (#24133)
  Revert "Use fibers to store context"
  Use fibers to store context
  Chore: Include REG_TOKEN in docker-compose (#24123)
  [FIX] Custom Emoji Image preview #24117
  [IMPROVE] Added a Reset Button in the Account Profile Page (#24078)
  Revert: "[IMPROVE] Throw 404 error in invalid endpoints" (#24118)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants