Skip to content

[BREAK] Webhook will fail if user is not part of the channel #23310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Sep 30, 2021
Merged

[BREAK] Webhook will fail if user is not part of the channel #23310

ggazzo merged 1 commit into from
Sep 30, 2021

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Sep 29, 2021

Proposed changes (including videos or screenshots)

Remove deprecated behavior added by #18024 that accepts webhook integrations sending messages even if the user is not part of the channel.

Starting from 4.0.0 the webhook request will fail with error-not-allowed error:

{"success":false,"error":"error-not-allowed"}

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team September 29, 2021 17:25
@ggazzo ggazzo merged commit fca74fa into develop Sep 30, 2021
@ggazzo ggazzo deleted the break-remove-integration-deprecated-behavior branch September 30, 2021 17:24
gabriellsh added a commit that referenced this pull request Sep 30, 2021
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into reg/…
0283848 
…requestSeatsUrl

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Webhook will fail if user is not part of the channel (#23310)
  Fixed channel sync and role sync (#23311)
  Regression: Request seats link (#23312)
This was referenced Oct 1, 2021
Merged
Closed
@ankar84 ankar84 mentioned this pull request Oct 11, 2021
Open
@morawskim morawskim mentioned this pull request Oct 23, 2021
Closed
@ankar84 ankar84 mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sampaiodiego @ggazzo