Skip to content

Regression: Deprecate check permission on integrations #18024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 2 commits into from
Jun 23, 2020
Merged

Regression: Deprecate check permission on integrations #18024

sampaiodiego merged 2 commits into from
Jun 23, 2020

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jun 23, 2020 •
edited by gabrieleiro
Loading

Proposed changes

Deprecate a permission check added to integrations.

Issue(s)

How to test or reproduce

  • Create an incoming webhook to a channel
  • Don't add the user to that channel
  • Test the webhook, it should fail with error-not-allowed

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.4.0 milestone Jun 23, 2020
graywolf336
graywolf336 reviewed Jun 23, 2020
View reviewed changes
@sampaiodiego sampaiodiego merged commit b8f447e into develop Jun 23, 2020
@sampaiodiego sampaiodiego deleted the regression-hooks branch June 23, 2020 20:46
gabriellsh added a commit that referenced this pull request Jun 23, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
98f02e9 
…geolocation_permission

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Deprecate check permission on integrations (#18024)
  Regression: Favorite and Featured fields not triggering changes (#18010)
  Regression: Fix setting reply-to email header (#18008)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
@sampaiodiego sampaiodiego mentioned this pull request Jul 24, 2020
Open
This was referenced Sep 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierre-lehnen-rc pierre-lehnen-rc Awaiting requested review from pierre-lehnen-rc

1 more reviewer

@graywolf336 graywolf336 graywolf336 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sampaiodiego @graywolf336