Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp
Copy link
Contributor Author

tiagoevanp commented Jul 26, 2021

This PR close this one -> #22761

Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-07-26 at 3 05 40 PM
I'm getting this error on the admin table

@MartinSchoeler
Copy link
Member

Screen Shot 2021-07-26 at 3 05 40 PM
I'm getting this error on the admin table

The same happens when I use the "all" option on the sidebar

Screen Shot 2021-07-26 at 3 09 16 PM

@KevLehman
Copy link
Member

That could be my mistake, can you share the request made by the client, so i can take a look at it @MartinSchoeler ?

@MartinSchoeler
Copy link
Member

That could be my mistake, can you share the request made by the client, so i can take a look at it @MartinSchoeler ?

offset=0&count=25 on the sidebar

text=&sort={%22shortcut%22:1}&count=25 on the admin table

@MartinSchoeler MartinSchoeler merged commit 8c38a11 into develop Jul 26, 2021
@MartinSchoeler MartinSchoeler deleted the regression/c-r-filter-contextualbar branch July 26, 2021 20:33
gabriellsh added a commit that referenced this pull request Jul 27, 2021
…ile_upload

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Data in the "New Users" section is delayed in 1 day (#22751)
  [FIX] Support ID param on createVisitor method (#22772)
  Regression: fix non ee tag field on canned responses (#22775)
  [FIX] Blank screen in message auditing DM tab (#22763)
  Show translated scope on cr dashboard (#22773)
  Regression: Fix empty tag field (#22767)
  Regression: Federation warnings on ci (#22765)
  Regression: fix outdated data on canned filters (#22766)
  [IMPROVE] Return open room if available for visitors (#22742)
  Regression: Fix empty canned responses table when searching (#22743)
  Regression: Filter of canned responses in contextual-bar (#22762)
  Regression: Fix users not being able to see the scope of the canned message (#22760)
  Regression: Fixes empty department field on edit canned responses (#22741)
  Regression: Allow users to update canned responses scope (#22738)
  allow users to search canned responses based on shortcut or content (#22735)
  Regression: Check for text before parse preview in create canned response form (#22754)
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants