Regression: Fixes empty department field on edit canned responses #22741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The |
KevLehman
reviewed
Jul 23, 2021
KevLehman
approved these changes
Jul 26, 2021
gabriellsh
added a commit
that referenced
this pull request
Jul 27, 2021
…ile_upload * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Data in the "New Users" section is delayed in 1 day (#22751) [FIX] Support ID param on createVisitor method (#22772) Regression: fix non ee tag field on canned responses (#22775) [FIX] Blank screen in message auditing DM tab (#22763) Show translated scope on cr dashboard (#22773) Regression: Fix empty tag field (#22767) Regression: Federation warnings on ci (#22765) Regression: fix outdated data on canned filters (#22766) [IMPROVE] Return open room if available for visitors (#22742) Regression: Fix empty canned responses table when searching (#22743) Regression: Filter of canned responses in contextual-bar (#22762) Regression: Fix users not being able to see the scope of the canned message (#22760) Regression: Fixes empty department field on edit canned responses (#22741) Regression: Allow users to update canned responses scope (#22738) allow users to search canned responses based on shortcut or content (#22735) Regression: Check for text before parse preview in create canned response form (#22754)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This fixes the empty department field when editing a canned response via table on omnichannel menu. this also convert some of the files to TS that were created in js initially, also created/adjusted some types