[FIX] Error in permission check for getLivechatDepartmentByNameOrId method in Apps #22545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
changed the title
|
We like / need this! Thank you. Look forward to it being merged. :) |
Contributor
|
Hello @d-gubert @sampaiodiego I tested this PR and the new changes looks good. I'm no longer getting the permission denied error. Thanks 😄 |
Member
Author
|
@murtaza98 we had this comment from the community about an issue RocketChat/Rocket.Chat.Apps-engine#429 (comment) - have you noticed any problems similar to that? |
Contributor
Yups I faced this same issue today while testing and I was able to fix it via this PR: #22587 |
sampaiodiego
approved these changes
Jul 7, 2021
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 7, 2021
Closed
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 8, 2021
Merged
aditya-mitra
added a commit
to aditya-mitra/Rocket.Chat
that referenced
this pull request
Jul 16, 2021
The custom message will be the sent for the first incoming in the channels selected by the OutOfOffice User Added a second model OutOfOfficeRooms to effectively carry out search and send the OutOfOffice message parent 6ef35ed author aditya-mitra <[email protected]> 1625465055 +0530 committer aditya-mitra <[email protected]> 1626418539 +0530 Add Post Message Handler The custom message will be the sent for the first incoming in the channels selected by the OutOfOffice User Added a second model OutOfOfficeRooms to effectively carry out search and send the OutOfOffice message add post message check [FIX] Omnichannel - Fix issue with modals on room preview mode. (RocketChat#22541) * Await error on main thread so meteor can handle it * Fix an issue where clicking esc would trigger a room read on unsubscribed rooms Co-authored-by: Renato Becker <[email protected]> [FIX] Redirect to login after delete own account (RocketChat#22499) [FIX] UIKit URL prop being ignored for buttons (RocketChat#22579) Chore: Upgrade NPM dependencies (RocketChat#22562) Chore: Upgrade Micro Services NPM dependencies (RocketChat#22561) [FIX] Create Discussion modal - Parent room input not displaying correct room name RocketChat#22580 [IMPROVE] Rewrite OTR modals (RocketChat#22583) * improve: rewrite accept otr modal * improve: rewrite otr end modal * improve: deny otr modal * fix: lint Co-authored-by: gabriellsh <[email protected]> i18n: Language update from LingoHub 🤖 on 2021-07-05Z (RocketChat#22572) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * remove translated variables Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> Chore: [Snyk] Security upgrade node-gcm from 0.14.4 to 1.0.0 (RocketChat#22582) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-LODASH-1040724 [FIX] Livechat webhook request without headers (RocketChat#22589) [IMPROVE] Rewrite Enter Encryption Password Modal (RocketChat#22456) * improve: rewrite modal * fix: modal props * fix: translation key * fix: review Co-authored-by: gabriellsh <[email protected]> [NEW] Convert Team to Channel (RocketChat#22476) * wip * Add extra param to listRoomsOfUser to filter rooms user can delete * update the way permission was being checked * new: convert team to channel * fix: lastOwner warning * fix: review * improve: convert ChannelDesertationTable to ts * Remove unused prop Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> [IMPROVE] Rewrite Save Encryption Password Modal (RocketChat#22447) * improve: rewrite modal * fix: translation keys * fix: review * fix: lint Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> [FIX] Error in permission check for getLivechatDepartmentByNameOrId method in Apps (RocketChat#22545) [FIX] Checks the list of agents if at least one is online (RocketChat#22584) Co-authored-by: Diego Sampaio <[email protected]> remove sent roomIds change OutOfOffice to OutOfOfficeUser model move date validation to update.ts correction in renaming (should be plural) add OutOfOfficeRooms model post message handler added fix lint errors [IMPROVE] Sidebar icons margins (RocketChat#22498) * Change components * Update fuselage Co-authored-by: Tasso Evangelista <[email protected]> [FIX] Convert Team to Channel menu order RocketChat#22606 Co-authored-by: Tasso Evangelista <[email protected]> [IMPROVE] Rewrite URL check modal (RocketChat#22540) * fix modal not being called * Rewrite url change modal Co-authored-by: Douglas Fabris <[email protected]> [FIX] Button overlapping modal RocketChat#22605 Co-authored-by: Tasso Evangelista <[email protected]> [FIX] User cannot delete own files in contextualbar RocketChat#22595 Co-authored-by: gabriellsh <[email protected]> Regression: Client crashing on startup (RocketChat#22610) [FIX] Confirm owner change process when deleting own account (RocketChat#22609) * fix: confirm owner change deleting own account * fix: missing return statement Co-authored-by: Tasso Evangelista <[email protected]> [FIX] Markdown for UiKit blocks (RocketChat#22619) Regression: Change the name of called methods in Users model (RocketChat#22620) [NEW] REST endpoint to remove User from Role (RocketChat#20485) * [WIP] added test * [WIP] added api endpoint to remove role from user * [WIP] added test with Subscription Scope * Update roles.js * fix endpoint params * update tests * remove .only Co-authored-by: Lucas Sartor Chauvin <[email protected]> Co-authored-by: Leonardo Ostjen Couto <[email protected]> Create README.md (RocketChat#22615) Add the Out of Office Scheduler Out of Office will be auto-disabled at the endDate and auto-enabled at the startDate Internally uses AgendaJS [FIX] VisitorClientInfo not showing (RocketChat#22593) * fix visitor info * fix prettier error * include host and ip Co-authored-by: Martin Schoeler <[email protected]> Chore: Use projection instead of fields to avoid error log (RocketChat#22629) fixed - room still listed after delete (RocketChat#22613) Co-authored-by: gabriellsh <[email protected]> [FIX] Prune messages from particular user(s) (RocketChat#22506) [FIX] Livechat apps permission error (RocketChat#22511) Bump version to 3.16.1 [FIX] Livechat webhook request without headers (RocketChat#22589) [FIX] Error in permission check for getLivechatDepartmentByNameOrId method in Apps (RocketChat#22545) [FIX] Checks the list of agents if at least one is online (RocketChat#22584) Co-authored-by: Diego Sampaio <[email protected]> Regression: Change the name of called methods in Users model (RocketChat#22620) Bump version to 3.16.2 Bump version to 3.16.3 [FIX] Info page - Instances card modal table width RocketChat#22627
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Update the Apps-Engine with a fix for the permission check on the
getLivechatDepartmentByNameOrIdmethodIssue(s)
Steps to test or reproduce
Further comments