Fix livechat bridge

[d-gubert]

What? ⛵

Fix wrong permission validation for livechat bridge

Why? 🤔

It's a fix. It's self explanatory

Links 🌎

PS 👀

[cuonghuunguyen]

Hi, could u cover the the bug in #430 also pls?

[d-gubert]

Hey @cuonghuunguyen ! This fix covers exactly that bug :)

[cuonghuunguyen]

Thank you very much!

[felipetomm]

Hi @d-gubert !
I think that issue persist partially. We have Apps runing in RocketChat 3.16.1 and 3.15.3 enterprise.
For example, an specific method getLivechatDepartmentByIdOrName, used for Omnichannel Apps, like Whatsapp and Telegram, run normally in the server on version 3.15.3, but in 3.16.1, the result from this method is undefined.

Please, can you review this?

[cuonghuunguyen]

Thats because while refactoring, they didnt add all permissions into defaultPermission

[felipetomm]

Hmm, but i think the permission of that method is livechat-department, right?
Has any way to adjust this without an RC release? I try add this in my App.json, but has no success:

...
"implements": [
        "IPostLivechatRoomStarted"
    ],
    "permissions": [
        {
            "name": "livechat-department.read"
        }
    ]
}

[felipetomm]

Ok.. with server logs, i find the correct permission: livechat-department.multiple, and that's ok for my App.
But, with external Apps, the solution is an Apps-Engine fix?

[d-gubert]

@felipetomm the livechat-department.multiple permission is only required for grabbing multiple departments with the getDepartmentsEnabledWithAgents method, other methods should work with ´livechat-department.read` as well. EDIT: I've found the problem regarding this, and you're right, this PR only solved it partially.

Regarding the difference in the apps, we'll be reviewing that.

@cuonghuunguyen the list of default permissions hasn't changed with the refactoring. But new permissions introduced after the permission system was implemented will not be part of this permission set. Currently, we have 2 permissions that are not default, IIRC: cloud.workspace-token and livechat-department.multiple

[felipetomm]

Thanks @d-gubert !

[murtaza98]

Hi @d-gubert !
I think that issue persist partially. We have Apps runing in RocketChat 3.16.1 and 3.15.3 enterprise.
For example, an specific method getLivechatDepartmentByIdOrName, used for Omnichannel Apps, like Whatsapp and Telegram, run normally in the server on version 3.15.3, but in 3.16.1, the result from this method is undefined.

Please, can you review this?

Hey guys, this should be fixed with this PR: RocketChat/Rocket.Chat#22587
It's currently under review and if all goes well, it will be released with the next core release