Skip to content

[FIX] Memory leak generated by Stream Cast usage #22329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 4 commits into from
Jun 21, 2021
Merged

[FIX] Memory leak generated by Stream Cast usage #22329

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a74c3d8
[FIX] Memory leak generated by Stream Cast usage
rodrigok Jun 12, 2021
048940c
Merge branch 'develop' into fix-streamcast-memory-leak
sampaiodiego Jun 15, 2021
05a116e
Fix streamcast leak
sampaiodiego Jun 14, 2021
76430af
Use registerStore only
sampaiodiego Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/stream/streamBroadcast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,11 @@ function startStreamCastBroadcast(value) {
_dontPrintErrors: LoggerManager.logLevel < 2,
});

// Ignore collection events to prevent store in memory
// necessary to prevent memory lead due to the usage
// of DDP subscribe
connection._livedata_data = () => {};

@sampaiodiego sampaiodiego Jun 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing this actually breaks streamcast, all events are ignored and communication doesn't happen.

another way of preventing this leak to happen, is to actually register a store for the broadcast-stream collection.

so I changed the current line 180 (connection._stream.on('message', function(raw_msg) { for the following code:

	connection.registerStore('broadcast-stream', {
		update({ fields }) {
			const { streamName, eventName, args } = fields;

			if (!streamName || !eventName || !args) {
				return;
			}

			if (connection.broadcastAuth !== true) {
				return 'not-authorized';
			}

			const instance = StreamerCentral.instances[streamName];
			if (!instance) {
				return 'stream-not-exists';
			}

			if (instance.serverOnly) {
				return instance.__emit(eventName, ...args);
			}
			return instance._emit(eventName, args);
		},
	});

looks like even a less hacky solution, wdyt?


connections[instance] = connection;
connection.instanceId = instance;
connection.instanceRecord = {};
Expand Down