Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jun 10, 2021

Proposed changes (including videos or screenshots)

This fix email notifications not using user's real name, even though the setting "Use Real Name" was enabled. There is an interesting bug going on as well, that if the Apps framework was enabled, this bug doesn't happen.

Issue(s)

Fixes #15125

Steps to test or reproduce

  • Disable Apps framework
  • Enable Use Real Name
  • Send a message that triggers a email notification to someone (the receiver user must have the email address verified)
  • Check out the email it will have only the sender's username

Further comments

@sampaiodiego sampaiodiego requested a review from a team June 10, 2021 12:12
@sampaiodiego sampaiodiego merged commit 66fb35b into develop Jun 21, 2021
@sampaiodiego sampaiodiego deleted the fix-notifications-without-name branch June 21, 2021 03:58
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Username" instead "Name" as sender in mail

4 participants