[FIX] name not saved with message in mongodb

[magicbelette]

Proposed changes

Issue(s)

Fixes #15125 and #18769

How to test or reproduce

When posting a message, name of the user is undefined so username is displayed in email notification and un threads :

Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:   event: 'sendMessage',
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:   message: {
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     _id: '8y7CS3ASgdcvERojW',
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     rid: 'zk6gRDSGwTH8zjw6u',
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     msg: 'hello',
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     ts: 2020-12-07T22:36:16.634,
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     u: { _id: 'zc5hgYoaP3br6g6CY', username: 'john.doe', name: undefined },
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     mentions: [],
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     channels: [],
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:     _updatedAt: 2020-12-07T22:36:16.656Z
Dec  7 21:42:50 ns3159562 rocketchat3000[2284]:   },

In mongodb

{
    "_id" : "8y7CS3ASgdcvERojW",
    "rid" : "zk6gRDSGwTH8zjw6u",
    "msg" : "hello",
    "ts" : ISODate("2020-12-07T22:36:16.634Z"),
    "u" : {
            "_id" : "zc5hgYoaP3br6g6CY",
            "username" : "john.doe",
    },
    "_updatedAt" : ISODate("2020-12-07T22:36:16.656Z"),
    "mentions" : [ ],
    "channels" : [ ]
}

Screenshots

Types of changes

• [ x] Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• [x ] I have read the CONTRIBUTING doc
• [ x] I have signed the CLA
• [ x] Lint and unit tests pass locally with my changes
• [x ] I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• [x ] Any dependent changes have been merged and published in downstream modules

Changelog

Fixes #15125 and #18769

Further comments

[muditjuneja]

This did fix the issue. Yes.

[CLAassistant]

All committers have signed the CLA.

[dougfabris]

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's duplicated now and it has been fixed here: #22309

---

Questions? Help needed? Feature Requests?

• Join our Open Server in the #support channel and feel free to raise a question
• Join our Community Forum and search/create a post there