[FIX] Support DISABLE_PRESENCE_MONITOR env var in new DB watchers #22257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
Jun 6, 2021
|
Am I get this right that using native oplog and |
Member
Author
|
hey @ankar84 this actually affects native oplog too.. I'll be probably releasing this in a patch for 3.15.x as well. |
This is a really good news, Diego! |
|
Sounds fantastic! |
sampaiodiego
added a commit
that referenced
this pull request
Jun 21, 2021
rodrigok
pushed a commit
that referenced
this pull request
Aug 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
With the introduction of micro services and the new DB watchers in #19000 the env var
DISABLE_PRESENCE_MONITORused to control whether an instance should be watching for user presence events was not being respected.Issue(s)
Steps to test or reproduce
Further comments