[NEW][Enterprise] Micro services #19000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 4a0f569 into 9daf8e4 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging b36bb69 into 61e4498 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c345e65 into 3b06de0 - view on LGTM.com new alerts:
|
# Conflicts: # app/lib/server/startup/userDataStream.js # app/models/server/raw/index.ts # definition/IMessage.ts # definition/IRoom.ts # definition/ISubscription.ts # definition/IUser.ts
sampaiodiego
commented
Oct 27, 2020
| } | ||
|
|
||
| export const msgStream = new MessageStream('room-messages'); | ||
| export const msgStream = notifications.streamRoomMessage; |
Member
Author
There was a problem hiding this comment.
this doesn't look to be used anywhere
Member
Author
There was a problem hiding this comment.
it is :( need to change that then
|
This pull request introduces 2 alerts when merging b453930 into 3995eec - view on LGTM.com new alerts:
|
rodrigok
approved these changes
Oct 28, 2020
|
This pull request introduces 1 alert when merging bd60936 into 3995eec - view on LGTM.com new alerts:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments