QoL improvements to add channel to team flow #21778
Conversation
app/api/server/v1/teams.ts
Outdated
|
|
||
| if (!hasPermission(this.userId, 'add-team-channel', team.roomId)) { | ||
| return API.v1.unauthorized(); | ||
| return API.v1.unauthorized('Teams_add_channel_no_permission'); |
There was a problem hiding this comment.
please use an error code instead.. something like error-no-permission-add-channel
looks like we need to standardize these errors 🤔
There was a problem hiding this comment.
Ah, didn't know the - were meant to be error codes, I'll change it.
app/models/server/raw/Rooms.js
Outdated
| }, | ||
| ], | ||
| name: nameRegex, | ||
| 'u._id': uid, |
There was a problem hiding this comment.
I know we used this filter on the other validation as well, but I don't think this is the correct way to validate what we need. this field actually stores the "creator" of the channel, which is formerly know as the owner, but we also have a owner role, which I think is more appropriate. Like when a user transfer the ownership of a channel we don't update the u field, we just give the new user the owner role.
the role is stored on Subscriptions, so here you could rely that filtered list of _ids where the user has the owner role..
There was a problem hiding this comment.
Yeah, I know about the owner role of the subs, I was trying to keep both filters the same (the one here and the one in the addRooms service.
If checking the subs is the way to go, I'll change this and the other :)
There was a problem hiding this comment.
yep, I think that is the expected behavior.. I didn't realize that before 🙈
There was a problem hiding this comment.
Yup, you're right on that 👀 we should've modified that validation before 😬
There was a problem hiding this comment.
@sampaiodiego what should be the behavior of the autocomplete then? Currently, it fetches all public channels and private channels the user is part of. Should this be changed to only show channels where the user is the owner (disregard if it's public/private)?
* rocketchat/master: (273 commits) Bump version to 3.14.0 Bump version to 3.14.0-rc.4 bump fuselage (RocketChat#21841) [FIX] Duplicated header on admin's user contextualbar (RocketChat#21810) Bump version to 3.14.0-rc.3 Bump Apps-Engine version (RocketChat#21840) [FIX][Enterprise] Omnichannel simultaneous chat limit is not properly checking the limit by department (RocketChat#21839) Fix node_modules cache path again Regression: Reactivate direct conversations only if all involved users are active (RocketChat#21714) Bump version to 3.14.0-rc.2 [FIX] Omnichannel Activity Monitor closing chats returned to the queue (RocketChat#21782) Fix node_modules cache path Regression: Problem with Importer's logs (RocketChat#21812) Chore: Add tests for teams.update REST endpoint (RocketChat#21653) QoL improvements to add channel to team flow (RocketChat#21778) Chore: Cache EE node_modules on CI (RocketChat#21831) Regression: team sync not accepting multiple teams (RocketChat#21768) regression: Italic being parsed with surrounding non-whitespace text (RocketChat#21815) Regression: Unread Threads Header and List (RocketChat#21816) Fix attachment previews. (RocketChat#21746) ...
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments